-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running in subdirectory returns churn
of 0
#461
Comments
rishijain
added a commit
to rishijain/rubycritic
that referenced
this issue
Oct 11, 2023
3 tasks
rishijain
added a commit
to rishijain/rubycritic
that referenced
this issue
Oct 11, 2023
rishijain
added a commit
to rishijain/rubycritic
that referenced
this issue
Oct 11, 2023
* bug fix * reek fixes * updated changelog
rishijain
added a commit
to rishijain/rubycritic
that referenced
this issue
Oct 18, 2023
* bug fix * reek fixes * updated changelog
etagwerker
pushed a commit
that referenced
this issue
Oct 18, 2023
@etagwerker Can we close this issue ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When running rubycritic in a subfolder, the Churn returns
0
.Example of a mono-repo where a subfolder is a Rails app, and other folders hold other components (eg. React app, docs, etc):
main-app
|-rails_app
|-docs
|-frontend
Running from the root directory works.
Steps to reproduce:
From the root directory:
From the subfolder:
Expectation: Both churn values should be the same regardless of where the rubycritic command is run
Side thought: This may just be a limitation of how the app calls git within a subfolder, but it's a gotcha when working with monorepos.
The text was updated successfully, but these errors were encountered: