Skip to content

Commit

Permalink
Merge branch 'master' into master
Browse files Browse the repository at this point in the history
  • Loading branch information
yuhongherald authored Mar 23, 2018
2 parents bf6529c + cc0fdf5 commit 988a077
Show file tree
Hide file tree
Showing 6 changed files with 19 additions and 20 deletions.
11 changes: 0 additions & 11 deletions docs/DeveloperGuide.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -1042,17 +1042,6 @@ field contents for each row. User then reviews the changes and generates a feedb
Done by: yuhongherald
User can set a custom keyword that is not used on top of the original command word.

*Feature contribution*:

- Importing job entries from an excel file (major enhancement)
Done by: yuhongherald
User can specify the file path to an excel file containing the job entries in columns, and header fields to indicate the
field contents for each row. User then reviews the changes and generates a feedback document.

- Setting custom command keywords (minor enhancement)
Done by: yuhongherald
User can set a custom keyword that is not used on top of the original command word.

[appendix]
== User Stories

Expand Down
5 changes: 5 additions & 0 deletions src/main/java/seedu/address/logic/LogicManager.java
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,11 @@ public ObservableList<Employee> getFilteredPersonList() {
return model.getFilteredJobList();
}

@Override
public ObservableList<Job> getFilteredJobList() {
return model.getFilteredJobList();
}

@Override
public ListElementPointer getHistorySnapshot() {
return new ListElementPointer(history.getHistory());
Expand Down
5 changes: 5 additions & 0 deletions src/main/java/seedu/address/model/AddressBook.java
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,11 @@ public ObservableList<Employee> getEmployeeList() {
return jobs.asObservableList();
}

@Override
public ObservableList<Job> getJobList() {
return jobs.asObservableList();
}

@Override
public ObservableList<Tag> getTagList() {
return tags.asObservableList();
Expand Down
6 changes: 3 additions & 3 deletions src/main/java/seedu/address/model/Model.java
Original file line number Diff line number Diff line change
Expand Up @@ -58,15 +58,15 @@ void updatePerson(Employee target, Employee editedEmployee)
/** Returns an unmodifiable view of the filtered employee list */
ObservableList<Employee> getFilteredPersonList();

/** Returns an unmodifiable view of the filtered employee list */
ObservableList<Job> getFilteredJobList();

/**
* Updates the filter of the filtered employee list to filter by the given {@code predicate}.
* @throws NullPointerException if {@code predicate} is null.
*/
void updateFilteredPersonList(Predicate<Employee> predicate);

/** Returns an unmodifiable view of the filtered job list */
ObservableList<Job> getFilteredJobList();

/**
* Updates the filter of the filtered job list to filter by the given {@code predicate}.
* @throws NullPointerException if {@code predicate} is null.
Expand Down
11 changes: 5 additions & 6 deletions src/main/java/seedu/address/model/ReadOnlyAddressBook.java
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,14 @@ public interface ReadOnlyAddressBook {
*/
ObservableList<Employee> getEmployeeList();

/**
* Returns an unmodifiable view of the jobs list.
* This list will not contain any duplicate jobs.
*/
ObservableList<Job> getJobList();

/**
* Returns an unmodifiable view of the tags list.
* This list will not contain any duplicate tags.
*/
ObservableList<Tag> getTagList();

/**
* Returns an unmodifiable view of the jobs list.
*/
ObservableList<Job> getJobList();
}
1 change: 1 addition & 0 deletions src/test/java/seedu/address/model/AddressBookTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ private static class AddressBookStub implements ReadOnlyAddressBook {
private final ObservableList<Employee> employees = FXCollections.observableArrayList();
private final ObservableList<Job> jobs = FXCollections.observableArrayList();
private final ObservableList<Tag> tags = FXCollections.observableArrayList();
private final ObservableList<Job> jobs = FXCollections.observableArrayList();

AddressBookStub(Collection<Employee> employees, Collection<Job> jobs, Collection<? extends Tag> tags) {
this.employees.setAll(employees);
Expand Down

0 comments on commit 988a077

Please sign in to comment.