Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patched linemod for kinect2 (using qhd) #38

Closed
wants to merge 3 commits into from
Closed

Patched linemod for kinect2 (using qhd) #38

wants to merge 3 commits into from

Conversation

vijendra1125
Copy link

No description provided.

@JimmyDaSilva
Copy link

@vijendra1125 This cannot be merged as it only works for the kinect2 and the QHD images as discussed in #28
Making this change permanent within linemod_detect.cpp will prevent all xtion and kinect1 users to use linemod

We need a better way of handling this and for the mean time a separate branch could be enough. But we cannot just merge this to the master branch

@vijendra1125
Copy link
Author

@JimmyDaSilva Sure, I agree. I didn't create it with the intention of merging. I just wanted to have a separate branch of Linemod for Kinect V2 so that new users could directly use it. I am a beginner and I just felt that if it will have separate branch then it will be easy for people who are new to it.

@vijendra1125 vijendra1125 deleted the kinect2-patch branch March 7, 2017 10:40
@JimmyDaSilva
Copy link

@vijendra1125 Yeah that's nice, but won't be merged that way. Maybe @vrabaud could consider having a separate branch with that temporary fix instead

@vijendra1125
Copy link
Author

@JimmyDaSilva Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants