Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transformation configs #101

Merged
merged 5 commits into from
May 13, 2024
Merged

Transformation configs #101

merged 5 commits into from
May 13, 2024

Conversation

JohannaOtt
Copy link
Member

SVC-1728

There currently is an issue with executing the gradle tasks on at least one PC using Windows 10 while they can be used on Linux. It should be part of the PR review to test if the issues can be reproduced with a second Windows environment.

Copy link
Member

@florianesser florianesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, mentioned just one minor change that needs to be done before the merge.

Tested gradlew transform-cp and gradlew transform-lu-ln successfully on Windows (for details see SVC ticket).

transformations.json Outdated Show resolved Hide resolved
For new models LB and LN as well as CityGML (was missing)

SVC-1728
For new models LB and LN

SVC-1728
Additionally add new ids for new transformation projects

SVC-1728
As the new transformations added in this PR have a suffix describing the model
used, the same is added to the existing transformation tasks.

SVC-1728
@JohannaOtt JohannaOtt merged commit c31fddb into master May 13, 2024
1 check passed
@JohannaOtt JohannaOtt deleted the transformation-configs branch May 13, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants