Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(components) feature: accessibility and math utilities #72

Merged
merged 2 commits into from
Jan 12, 2024
Merged

(components) feature: accessibility and math utilities #72

merged 2 commits into from
Jan 12, 2024

Conversation

marlonmarcello
Copy link
Contributor

@marlonmarcello marlonmarcello commented Jan 12, 2024 •
edited
Loading

Description

Adds the accessibility and math utilities.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 12, 2024

⚠️ No Changeset found

Latest commit: e33462d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@marlonmarcello marlonmarcello changed the title Feature/accessibility utilities (components) feature: visibility and math utilities Jan 12, 2024
@marlonmarcello marlonmarcello self-assigned this Jan 12, 2024
@marlonmarcello marlonmarcello added the enhancement New feature or request label Jan 12, 2024
@marlonmarcello marlonmarcello added this to the v1 milestone Jan 12, 2024
@marlonmarcello marlonmarcello changed the title (components) feature: visibility and math utilities (components) feature: accessibility and math utilities Jan 12, 2024
@marlonmarcello marlonmarcello added DOCS Improvements or additions to Storybook docs COMP Tickets related to wethegit-components labels Jan 12, 2024
rvno
rvno approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@rvno rvno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skimming over the code changes things lgtm

liamegan
liamegan approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@liamegan liamegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marlonmarcello marlonmarcello merged commit 4feacc0 into feature/visibility-utilities Jan 12, 2024
5 checks passed
@marlonmarcello marlonmarcello deleted the feature/accessibility-utilities branch January 12, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvno rvno rvno approved these changes

@liamegan liamegan liamegan approved these changes

@andrewrubin andrewrubin Awaiting requested review from andrewrubin

@ste-vg ste-vg Awaiting requested review from ste-vg

@NicholasLancey NicholasLancey Awaiting requested review from NicholasLancey

@chanroyc chanroyc Awaiting requested review from chanroyc

Assignees

@marlonmarcello marlonmarcello

Labels
COMP Tickets related to wethegit-components DOCS Improvements or additions to Storybook docs enhancement New feature or request
Projects
None yet
Milestone
v1
Development

Successfully merging this pull request may close these issues.
3 participants
@marlonmarcello @liamegan @rvno