Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(cli) fix: ensure TS is ignored if set to false and fix glob selection #68

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

marlonmarcello
Copy link
Contributor

@marlonmarcello marlonmarcello commented Dec 12, 2023

Description

Fixes #66

Solution

Fixed the glob pattern and the default value for the TS.

How to test

Please follow the instructions on the CLI docs:
https://github.com/wethegit/component-library/tree/main/packages/wethegit-components-cli#developing

Copy link

changeset-bot bot commented Dec 12, 2023

🦋 Changeset detected

Latest commit: 00f20f1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@wethegit/components-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@marlonmarcello marlonmarcello changed the title fix > cli: ignore ts and stories on copy (cli) fix: title Dec 12, 2023
@marlonmarcello marlonmarcello changed the title (cli) fix: title (cli) fix: ensure TS is ignored if set to false and fix glob selection Dec 12, 2023
@marlonmarcello marlonmarcello self-assigned this Dec 12, 2023
@marlonmarcello marlonmarcello added bug Something isn't working CLI Tickets related to wethegit-components-cli labels Dec 12, 2023
@marlonmarcello marlonmarcello added this to the v1 milestone Dec 12, 2023
@andrewrubin
Copy link
Member

Nice one, tested and working, thanks 🙌

@marlonmarcello marlonmarcello merged commit 7ffdcd3 into main Dec 12, 2023
1 check passed
@marlonmarcello marlonmarcello deleted the fix/ts-and-stories-copied-on-filter branch December 12, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLI Tickets related to wethegit-components-cli
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CLI] Components imported as Typescript even though option was set to negative
2 participants