Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(components) feature: upgraded the Modal to @wethegit/react-modal v3 #350

Merged
merged 7 commits into from
Oct 3, 2024

Conversation

pravton
Copy link
Contributor

@pravton pravton commented Sep 24, 2024

Description

Upgraded the Modal component to use the latest version (v3) of @wethegit/react-modal which addresses the issue #318

Task: https://wethecollective.teamwork.com/app/tasks/22769488

@pravton pravton requested a review from a team as a code owner September 24, 2024 23:49
Copy link

changeset-bot bot commented Sep 24, 2024

🦋 Changeset detected

Latest commit: 082a0e5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@wethegit/components Major
@wethegit/components-cli Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@andrewrubin andrewrubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @pravton! Couple notes from me, but we also need to clean up the docs:

This sentence is incorrect (there's no trigger prop on the Modal):

The component takes a trigger prop that is a function which receives a toggle function as its only argument and should return the element that will trigger the modal.

Can we just re-word some of these docs to explain the usage better, i.e. how the useModal hook returns the props required for the Modal itself (toggle and triggerRef), as well as the isOpen state.

@pravton
Copy link
Contributor Author

pravton commented Sep 25, 2024

@andrewrubin I have also updated the readme and the example and ready for you when you have a moment!

@andrewrubin
Copy link
Member

It's looking good to me @pravton. I think we're ready for a changeset on this one 🎉

@andrewrubin andrewrubin merged commit 80eaa8b into main Oct 3, 2024
4 checks passed
@andrewrubin andrewrubin deleted the feature/modal-upgrade branch October 3, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants