Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update GH action node to use .nvmrc #245

Merged
merged 3 commits into from
May 31, 2024
Merged

fix: update GH action node to use .nvmrc #245

merged 3 commits into from
May 31, 2024

Conversation

marlonmarcello
Copy link
Contributor

@marlonmarcello marlonmarcello commented May 31, 2024 •
edited
Loading

Description

Small maintenance fix to use the NVMRC file for GH actions.

Closes #149

@marlonmarcello marlonmarcello requested a review from a team as a code owner May 31, 2024 22:20
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 31, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4876a8d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@marlonmarcello marlonmarcello self-assigned this May 31, 2024
@marlonmarcello marlonmarcello added the enhancement New feature or request label May 31, 2024
@marlonmarcello marlonmarcello linked an issue May 31, 2024 that may be closed by this pull request
Update Actions to support Node 20 #149
Closed
@marlonmarcello marlonmarcello changed the title fix: update GH action node to use nvmrc fix: update GH action node to use .nvmrc May 31, 2024
andrewrubin
andrewrubin previously approved these changes May 31, 2024
View reviewed changes
@marlonmarcello marlonmarcello dismissed andrewrubin’s stale review May 31, 2024 23:07

The merge-base changed after approval.

@marlonmarcello marlonmarcello merged commit e120baa into main May 31, 2024
3 checks passed
@marlonmarcello marlonmarcello deleted the fix/node-version-on-actions branch May 31, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewrubin andrewrubin andrewrubin approved these changes

Assignees

@marlonmarcello marlonmarcello

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Actions to support Node 20
2 participants
@marlonmarcello @andrewrubin