Client-side timeouts #268
Merged
Client-side timeouts #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The connection monitor is a thread we spawn for each RPC; it's job is to monitor the connection and close the RPC if the entire connection is closed. In order to prevent memory leaks, the thread also terminates when the RPC is closed independent of the connection. However, we were waiting for termination of the _outbound_ thread to determine if the RPC is closed; it's better to wait for termination of the _inbound_ thread, because the outbound thread is terminated when the client sends its final message, but at that point we might still be waiting on further messages from the server. This doesn't matter too much, but becomes important in the next commit.
edsko
force-pushed
the
edsko/issue-221
branch
from
5a50160 to
5dc19e7
Compare
The problem is not that the client imposes a local timeout, this is per the spec; the moment is that the server closes the connection in response to the deadline but without sending the appropriate error.
edsko
force-pushed
the
edsko/issue-221
branch
from
5dc19e7 to
0ad6492
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.