Add pagination and fix N+1 query issue for People index #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esteres
force-pushed
the
fix/performance-issues
branch
from
cdc7b79 to
deca0d6
Compare
esteres
force-pushed
the
fix/performance-issues
branch
from
deca0d6 to
30545ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced pagination using Kaminari for the People index (10 entries per page) and fixed an N+1 query issue by eager loading Companies with People for better performance.
Improve view spec for index view, not pretending to test pagination here, but at least making sure its present when we have more than 10 records
Note: Didn't include any addition/improvement to feature spec here due to the kind of changes done, no much user interaction to be tested, besides loading index page.
Screenshot: