Support for providing commands to run from external source #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic handleInput() method
AmbientLion
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've implemented a minor, but useful enhancement to react-console, which allows an input command to be provided from an external source, through a new public method "handleInput(commandText:string)". This makes it possible to do things like add other input elements (e.g. button, anchor) that when interacted with run a command. It also makes it possible to "script" a sequence of inputs, without requiring user interaction.
To the extent possible, I have preserved the existing structure and style of the original code. There were not existing automated unit tests to update for this project, but I've tested this manually with a variety of use cases and to ensure that existing behavior continues to work as expected. No changes to the props/state of the ReactConsole component were needed. The new functionality works with existing history mechanisms as well as input validation.