-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the ConvTranspose operation #182
base: master
Are you sure you want to change the base?
Conversation
63ce8e5
to
8ec1e4e
Compare
8a981e1
to
4b3b6e8
Compare
4b3b6e8
to
cc04616
Compare
Okay, I think we have the most important features of We are missing support for 1D and 3D, @pixelspark I didn't run the ONNX backend tests locally, so we'll have to see if the CI check passes. Do you want me to annotate the limitations in the support table in the README? |
Also, as I mentioned before, this was the missing step for me to run UNet. I have successfully used this to run a pretrained nind-denoise model. Creating a randomized graph might be a nice way to test the functionality but won't provide any further use to anyone. |
@mayjs backend test appears to have passed? Re the UNet sample: how large would the download size be for running the example/test? I might be able to host the files (I have a VPS with some traffic budget). |
@pixelspark Hm, looking through the log files (https://github.com/webonnx/wonnx/actions/runs/5843079870/job/15844866120?pr=182), ConvTranspose is not listed in the loaded / supported operations. Not sure where the operations are registered, but it's looking like the ConvTranspose backend tests are not running. I'll look into that. The model I'm using is about 57MB. |
Hm, maybe I'm misunderstanding something. Any idea why the test is not executed? Or am I just not reading the output correctly? |
Probably the easiest way to fix this would be to run the tests locally... I can try later if necessary. |
Yeah I guess that would be easier - I didn't have time to setup the required Python environment and I suspect that it might take a bit of work for me since I'm on NixOS, so if you have time to take a look at this that would be great :) |
I have a first draft of a working ConvTranspose implementation.
Still want to add support for padding and maybe groups before we merge this.
Also should probably handle some more edgecases for unsupported attribute values to at least throw an informative error.