feat: new nav macros #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -148,6 +148,10 @@ enum MetaMacros { | |||
| cssref = 'cssref', | |||
| jsref = 'jsref', | |||
| jssidebar = 'jssidebar', | |||
| glossarysidebar = 'glossarysidebar', | |||
| htmlsidebar = 'htmlsidebar', | |||
| svgref = 'svgref', | |||
There was a problem hiding this comment.
the output of meta macros goes separately from other content. So, first:
- all sidebars should go to meta macros, otherwise they'll output directly into the page and it won't end up well.
- there also changes to be made on platform, because it also recognizes only a certain subset of macros
There was a problem hiding this comment.
So, yes: your change is absolutely necessary here, and also it's no sufficient to get the structure displayed on UI
There was a problem hiding this comment.
No worries, I debugged everything in https://github.com/webdoky/platform-next, just wasn't always sure I know what I'm doing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be honest, I'm not sure if this change is necessary