Add ExorcismAcademy #289
Open
Add ExorcismAcademy #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmoonfire
force-pushed
the
ExorcismAcademy
branch
from
d2ac7ad
to
809796f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #289 +/- ##
==========================================
- Coverage 82.05% 82.00% -0.05%
==========================================
Files 79 79
Lines 6649 6664 +15
Branches 525 525
==========================================
+ Hits 5456 5465 +9
- Misses 1073 1079 +6
Partials 120 120 ☔ View full report in Codecov by Sentry. |
TobiX
reviewed
Oct 8, 2023
| multipleImagesPerStrip = True | ||
| adult = True | ||
|
|
||
| def namer(self, image_url, page_url): |
There was a problem hiding this comment.
Is this just a more fancy version of joinPathPartsNamer? Wouldn't it make sense to expand that instead?
There was a problem hiding this comment.
I'm sorry, I haven't figured out how use joinPathPartsNamer to zero-pad and pull out elements. Or to split on the preceding "-" (which is not always there).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ExorcismAcademy from https://ea.asmodrawscomics.com/
The namer is use to attempt to create a lexical ordering (four-digit zero pad) by moving the "Pg-\d+" in the file name to the beginning.