Fix: Issue-317 set autocomplete attribute for search countries input #454
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pasevin @webcat12345 please have a look |
webcat12345
requested changes
May 30, 2022
| @@ -21,6 +21,7 @@ | |||
| (keyup)="searchCountry()" | |||
| (click)="$event.stopPropagation()" | |||
| [placeholder]="searchCountryPlaceholder" | |||
| [autocomplete]="searchCountryAutocomplete" | |||
There was a problem hiding this comment.
This parameter name doesn't match with the functionality. Please make it more readable. searchCountryAutocomplete maybe. And make it boolean not string.
There was a problem hiding this comment.
Thanks for the reply I will make it boolean. What do you mean with "searchCountryAutocomplete maybe", it's literally the same name i used. What about enableSearchCountryAutocomplete?
Also do you think it should be enabled or disabled by default?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an open issue requesting this. This simple feature saves innecesary code for removing the default browser suggestions for the search countries input that overlaps the countries dropdown.