Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #88: Mark as bad any run with >=66 missing results #93

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gsnedders
Copy link
Member

This is a high enough threshold that it doesn't exclude runs with missing results (e.g., due to -print or -crash being unsupported), but does catch the vast majority with an unusually high number of missing
results.

This is a high enough threshold that it doesn't exclude runs with
missing results (e.g., due to -print or -crash being unsupported), but
does catch the vast majority with an unusually high number of missing
results.
@gsnedders gsnedders requested a review from foolip July 7, 2022 16:05
@gsnedders gsnedders marked this pull request as draft July 7, 2022 18:32
@gsnedders
Copy link
Member Author

@gsnedders
Copy link
Member Author

Oh, actually, maybe my data is bad here; seems to omit cases where entire trees are missing.

@foolip
Copy link
Member

foolip commented Jul 8, 2022

@gsnedders what are some of the runs that you're hoping this will exclude? Any idea what went wrong with them?

I would quite like it if we used the manifest when processing results in wpt.fyi, so that we could tell if a run is complete or not and label incomplete runs, or at least know for sure how many tests of which type are missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants