Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checklist for handling BCD upgrades #2043

Merged
merged 2 commits into from
Oct 24, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions .github/workflows/bcd_upgrade_checklist.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
name: BCD upgrade

on:
pull_request:
types: [opened]
jobs:
post-comment:
name: "Post checklist"
runs-on: ubuntu-latest
if: github.event.pull_request.user.login == 'dependabot[bot]'
steps:
- id: dependency
run: |
if ! git diff --exit-code -G '@mdn/browser-compat-data' "${{ github.event.pull_request.base.sha }}" "${{ github.sha }}"; then
echo "is_bcd=true" >> $GITHUB_OUTPUT
fi
exit 0
- if: ${{ steps.dependency.outputs.is_bcd == 'true' }}
uses: peter-evans/create-or-update-comment@71345be0265236311c031f5c7866368bd1eff043 #v4.0.0
with:
issue-number: ${{ github.event.number }}
body: |
Complete this checklist for every `@mdn/browser-compat-data` upgrade PR:

- [ ] Check out this branch locally.
- [ ] If any keys were removed in the release, delete them from `.yml` files.
- [ ] Run `npm install && npm run dist && npm test && git commit --all --message="Refresh dist"`.
- [ ] Review the diff. Watch out for Baseline regressions; if applicable, add a comment (see https://github.com/web-platform-dx/web-features/issues/1971).
- [ ] Start a PR to [publish the next web-features release](https://github.com/web-platform-dx/web-features/blob/main/docs/publishing.md#regular-releases).
- [ ] Merge this PR.
ddbeck marked this conversation as resolved.
Show resolved Hide resolved
- [ ] [Trigger a drafts update workflow run](https://github.com/web-platform-dx/web-features/actions/workflows/update_draft_features_weekly.yml).