Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Navigator and more navigation pieces #1931

Merged
merged 30 commits into from
Oct 25, 2024
Merged

Add Navigator and more navigation pieces #1931

merged 30 commits into from
Oct 25, 2024

Conversation

autonome
Copy link
Collaborator

@autonome autonome commented Oct 9, 2024

No description provided.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Oct 9, 2024
ddbeck
ddbeck reviewed Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question and two suggestions for you. Looking pretty close though.

features/navigator.yml Outdated Show resolved Hide resolved
features/navigator.yml.dist Outdated Show resolved Hide resolved
features/navigation.yml Outdated Show resolved Hide resolved
autonome and others added 2 commits October 14, 2024 02:15
@autonome @ddbeck
Update features/navigation.yml
56e8180 
Co-authored-by: Daniel D. Beck <[email protected]>
@autonome @ddbeck
Update features/navigator.yml
aa1e497 
Co-authored-by: Daniel D. Beck <[email protected]>
captainbrosset
captainbrosset previously requested changes Oct 14, 2024
View reviewed changes
features/navigator.yml.dist Outdated Show resolved Hide resolved
@autonome autonome marked this pull request as draft October 15, 2024 09:39
@autonome autonome marked this pull request as ready for review October 21, 2024 06:44
ddbeck
ddbeck requested changes Oct 23, 2024
View reviewed changes
features/client-identification.yml Outdated Show resolved Hide resolved
features/cookie-enabled.yml Outdated Show resolved Hide resolved
features/hardware-concurrency.yml Outdated Show resolved Hide resolved
features/language.yml.dist Show resolved Hide resolved
features/navigator.yml Outdated Show resolved Hide resolved
features/online.yml Outdated Show resolved Hide resolved
features/online.yml Outdated Show resolved Hide resolved
features/pdf-viewer.yml Outdated Show resolved Hide resolved
features/pdf-viewer.yml Outdated Show resolved Hide resolved
features/registerprotocolhandler.yml Outdated Show resolved Hide resolved
@autonome autonome mentioned this pull request Oct 24, 2024
Open
@autonome autonome requested a review from ddbeck October 24, 2024 04:39
This was referenced Oct 24, 2024
Merged
Merged
Merged
ddbeck
ddbeck approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One optional description amendment for you. Feel free to merge in any case.

features/user-agent-sniffing.yml Outdated Show resolved Hide resolved
@autonome autonome dismissed captainbrosset’s stale review October 25, 2024 03:11

review comments resolved

@autonome autonome merged commit 2f45ab0 into web-platform-dx:main Oct 25, 2024
3 checks passed
@autonome autonome deleted the navigation branch October 25, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddbeck ddbeck ddbeck approved these changes

@captainbrosset captainbrosset Awaiting requested review from captainbrosset

Assignees
No one assigned
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@autonome @ddbeck @captainbrosset