Update dashlist panel #670
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since at least Grafana 7, the settings for Dashboard Lists are under the 'options' block in the Panel JSON.
padraic-padraic
force-pushed
the
update-dashlist-panel
branch
from
a3a3a39
to
79d94c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Improves the DashboardList panel for recent versions of Grafana, and adds option to filter by Folder.
Additionally, we add an import for
attrs.validator.optional; it's a useful validator that's already used a lot in the code,so it may as well be imported so it can be used with the shorthand
optionalinstead.Why is it a good idea?
This allows grafanalib users to make use of the full functionality of DashboardLists panels.