-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: return resultaat values #454
base: master
Are you sure you want to change the base?
feat: return resultaat values #454
Conversation
<SenderPipe name="GetAuthorizationHeaderForZakenApi" | ||
getInputFromFixedValue="<dummy/>" storeResultInSessionKey="Authorization"> | ||
<IbisLocalSender | ||
name="GetAuthorizationHeaderForZakenApiSender" | ||
javaListener="GenerateAuthorizationHeaderForZakenApi" | ||
returnedSessionKeys="Error,Authorization"> | ||
</IbisLocalSender> | ||
<Forward name="success" path="GetResultaatSender" /> | ||
<Forward name="exception" path="EXCEPTION" /> | ||
</SenderPipe> | ||
|
||
<SenderPipe | ||
name="GetResultaatSender" | ||
getInputFromSessionKey="originalMessage" | ||
> | ||
<HttpSender | ||
name="GetResultaatSender" | ||
methodType="GET" | ||
headersParams="Authorization,Accept-Crs" | ||
timeout="${zaakbrug.zgw.zaken-api.timeout}" | ||
maxExecuteRetries="5" | ||
/> | ||
<Param name="url" sessionKey="ZgwZaak" | ||
xpathExpression="//resultaat" | ||
/> | ||
<Param name="Accept-Crs" value="EPSG:4326" /> | ||
<Param name="Authorization" xpathExpression="concat('Bearer ', $token)"> | ||
<Param name="token" sessionKey="Authorization"/> | ||
</Param> | ||
<Forward name="success" path="Json2XML" /> | ||
<Forward name="exception" path="EXCEPTION" /> | ||
</SenderPipe> | ||
|
||
<JsonPipe name="Json2XML" storeResultInSessionKey="Resultaat"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be in it's own adapter named Zaken_GetZgwResultaatByUrl
. Should look similar to Zaken_GetZgwRolTypeByUrl
. You will also need ZgwResultaatType, which will also need it's own adapter named Zaken_GetZgwResultaatTypeByUrl
.
<XsltPipe name="EnrichZdsZaakWithResultaat" | ||
getInputFromSessionKey="ZdsZaak" | ||
storeResultInSessionKey="ZdsZaak" | ||
styleSheetName="geefZaakdetails_Lv01/xsl/AddResultaat.xsl" | ||
> | ||
<Param name="Resultaat" sessionKey="Resultaat" type="DOMDOC"/> | ||
<Forward name="success" path="EXIT"/> | ||
<Forward name="error" path="EXCEPTION"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resultaat is a bit of a weird one, because in ZGW it is a seperate resource attached to a zaak, but in ZDS it is actually part of a zaak. It's not even similar to ZDS heeftAls*, heeft, etc. which are considered "topfundementeel". In ZDS, resultaat is just another element on a zaak.
For that reason, the translation for resultaat should be part of the xslt translating ZgwZaak to ZdsZaak. ZgwResultaat and ZgwResultaatType can be optionally provided via Params there. If no resultaat is provided, the resultaat element should be absent.
<xsl:template match="ZKN:startdatum"> | ||
<ZKN:resultaat> | ||
<ZKN:omschrijving> | ||
<xsl:value-of select="$Resultaat/root/toelichting" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ZKN:omschrijving should come from ZgwResultaatType->omschrijving. ZKN:toelichting should come from ZgwResultaat->toelichting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do?:
merge from main
No description provided.