fix: updateZaak incorrectly distinguishes roles due to 'authentiek' dataloss in translation resulting in attempt to add as new role #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mericakgul
commented
Jul 8, 2024
mericakgul
commented
- 'Authentiek' field is not represented in Openzaak so we are mapping this field statically with the value 'J' from Zgw to Zds.
- In case this field has the value 'N' in updateZaak message in one of the role elements then the comparison fails and we interpret it as a different role while it is the same role and we try to add the same role again and we get error because the rol already exists in Openzaak.
- Because this field is not represented in Openzaak and mapped statically from zgw to zds by us, we are now skipping to compare this field while comparing two roles to see if they are the same roles.
added 5 commits
July 8, 2024 16:49
MLenterman
changed the title
MLenterman
approved these changes
Jul 16, 2024
WeAreFrank-BOT
pushed a commit
that referenced
this pull request
Jul 16, 2024
## [1.19.16](v1.19.15...v1.19.16) (2024-07-16) ### 🐛 Bug Fixes * defaultProfile not being used when there is no zaaktype specific translation profile configured ([#402](#402)) ([179c468](179c468)) * updateZaak incorrectly distinguishes roles due to 'authentiek' dataloss in translation resulting in attempt to add as new role ([#418](#418)) ([266d9ca](266d9ca)) ### 🤖 Build System * **dependencies:** bump the github-actions group across 1 directory with 3 updates ([#422](#422)) ([77ed198](77ed198))
|
🎉 This issue has been resolved in version 1.19.16 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.