Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset password not working #1433

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

sapayth
Copy link
Member

@sapayth sapayth commented Feb 2, 2024

Using Forgot-password and setting new password is not working ---> The old password is still being used to perform login-action and the new-set password is not working at all

fix #558

@Rat01047
Copy link

Rat01047 commented Feb 5, 2024

Enhancement Request:
Can we add a success message once we click "Get New Password" button

Scenario-1:

  1. Login Page > Click Lost Password
  2. Enter Email > Click "Get New Password" button --> Add a success message that Email has been sent to the entered email

Screenshot for reference:
http://tinyurl.com/2468tjlp

Scenario-2:

  1. Enter New Password
  2. Confirm new Password
  3. No Success Message ---> Add a Successful message of "New password has been set"

Video for reference:
https://www.awesomescreenshot.com/video/24659331?key=6e1976d74af8ea50b4155dd74cdd6fb6

@anik-fahmid
Copy link

anik-fahmid commented Feb 5, 2024

@sapayth vai, please add the success messages:

  • Scenario 1: We've just sent an email to the address provided with instructions on how to reset your password. Please check your inbox.

  • Scenario 2: Your password has been successfully reset. You can now log in with your new password.

@sapayth
Copy link
Member Author

sapayth commented Feb 5, 2024

@anik bhai, we already have translated text for
Scenario 1: Check your e-mail for the confirmation link.
Scenario 2: Your password has been reset successfully

So continuing with the current messages for now.

@Rat01047 Rat01047 added QA Approved This PR is approved by the QA team Ready to Merge This PR is now ready to be merged and removed QA In Progress labels Feb 6, 2024
@sapayth sapayth merged commit e2257f1 into weDevsOfficial:develop Feb 6, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA Approved This PR is approved by the QA team Ready to Merge This PR is now ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants