Implement a new KeyStore file to configure the persistence logic #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion. Add PluginSettingTest
Signed-off-by: Álex Ruiz <[email protected]>
AlexRuiz7
reviewed
Oct 14, 2024
plugins/command-manager/src/main/java/com/wazuh/commandmanager/settings/PluginSettings.java
Outdated
Show resolved
Hide resolved
plugins/command-manager/src/main/java/com/wazuh/commandmanager/settings/PluginSettings.java
Outdated
Show resolved
Hide resolved
plugins/command-manager/src/main/java/com/wazuh/commandmanager/settings/PluginSettings.java
Outdated
Show resolved
Hide resolved
plugins/command-manager/src/main/java/com/wazuh/commandmanager/settings/PluginSettings.java
Outdated
Show resolved
Hide resolved
plugins/command-manager/src/main/java/com/wazuh/commandmanager/settings/PluginSettings.java
Outdated
Show resolved
Hide resolved
plugins/command-manager/src/main/java/com/wazuh/commandmanager/settings/PluginSettings.java
Outdated
Show resolved
Hide resolved
plugins/command-manager/src/test/resources/wazuh-indexer.keystore.json
Outdated
Show resolved
Hide resolved
.../command-manager/src/main/java/com/wazuh/commandmanager/settings/CommandManagerSettings.java
Show resolved
Hide resolved
…plugin and the keystore load in this class.
…nit test. Also delete the PluginSettings class.
…95-configuration-persistence-logic
…s. Change the settings name.
…tings of CommandManagerSettings
AlexRuiz7
approved these changes
Oct 22, 2024
.../command-manager/src/main/java/com/wazuh/commandmanager/settings/CommandManagerSettings.java
Outdated
Show resolved
Hide resolved
AlexRuiz7
reviewed
Oct 22, 2024
.../command-manager/src/main/java/com/wazuh/commandmanager/CommandManagerSettingsException.java
Outdated
Show resolved
Hide resolved
…/wazuh-indexer-plugins into 95-configuration-persistence-logic
Opensearch solutionWe ask for help to OpenSearch for managing the Settings in the Keystore, and they give us a simple solution: The plugins can declare "secure" settings and then they will have access to the decrypted value directly. They only have access to their own declared secure settings, but not secure settings declared by other plugins They can be declared like this and they can be accessed like any other setting. The different between secureSetting vs normal setting is that secureSetting is stored in the keystore. So we are going to refactor the code to simplify the solution. |
… pattern to CommanfManagerSettings.
AlexRuiz7
reviewed
Oct 25, 2024
plugins/command-manager/src/test/resources/wazuh-indexer.keystore.json
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the configuration persistence method, so the Command Manager plugin can send data to the Management API in the server. With this, it will know the endpoint of its HTTP Rest API and its credentials in order to establish the communication.
Issues Resolved
#95