-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to edit the wazuh.updates.disabled setting from UI #7156
Merged
asteriscos
merged 10 commits into
4.10.0
from
enhancement/7152-allow-edit-wazuh-updates-disabled-setting-from-ui
Nov 14, 2024
Merged
Add ability to edit the wazuh.updates.disabled setting from UI #7156
asteriscos
merged 10 commits into
4.10.0
from
enhancement/7152-allow-edit-wazuh-updates-disabled-setting-from-ui
Nov 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from UI - Side changes: - Enhance description for wazuh.updates.disabled setting
…ting was disabled the UI was displayed
…tom hook with the platform loadingCount
6 tasks
2 tasks
2 tasks
…to enhancement/7152-allow-edit-wazuh-updates-disabled-setting-from-ui
asteriscos
previously approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test | Chrome | Firefox | Safari |
---|---|---|---|
Go to Dashboard management > App Settings and ensure the wazuh.updates.disabled is displayed and can be configured (try to save both possible values). | 🟢 | 🟢 | ⚪ |
With wazuh.updates.disabled enabled (true), the UI related to check updates (bottom bar, data in Server APIs) should not appear. | 🟢 | 🟢 | ⚪ |
With wazuh.updates.disabled disabled (false), the UI related to check updates (bottom bar, data in Server APIs) should appear (ensure you did not dismiss it). | 🟢 | 🟢 | ⚪ |
Chrome 🟢
Peek.2024-11-14.17-10.mp4
Firefox 🟢
Peek.2024-11-14.17-16.mp4
TestLegend: UI
Details ChromeScreen.Recording.2024-11-14.at.1.32.51.PM.movSafariScreen.Recording.2024-11-14.at.1.33.57.PM.mov |
Machi3mfl
previously approved these changes
Nov 14, 2024
…disabled-setting-from-ui
asteriscos
approved these changes
Nov 14, 2024
Machi3mfl
approved these changes
Nov 14, 2024
|
|
|
asteriscos
deleted the
enhancement/7152-allow-edit-wazuh-updates-disabled-setting-from-ui
branch
November 14, 2024 16:56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds the ability to edit the
wazuh.updates.disabled
setting from UI.Changes:
wazuh.updates.disabled
setting from UI.Issues Resolved
#7152
Evidence
Test
Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable
UI
Details
⚫ Go to Dashboard management > App Settings and ensure the wazuh.updates.disabled is displayed and can be configured (try to save both possible values).
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ With wazuh.updates.disabled enabled (true), the UI related to check updates (bottom bar, data in Server APIs) should not appear.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ With wazuh.updates.disabled disabled (false), the UI related to check updates (bottom bar, data in Server APIs) should appear (ensure you did not dismiss it).
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
Check List
yarn test:jest