Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to edit the wazuh.updates.disabled setting from UI #7156

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Nov 14, 2024

Description

This pull request adds the ability to edit the wazuh.updates.disabled setting from UI.

Changes:

  • Add the ability to edit the wazuh.updates.disabled setting from UI.
  • Fix a problem when the wazuh.updates.disabled setting was enabled, the UI was displayed

Issues Resolved

#7152

Evidence

image

Test

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
Go to Dashboard management > App Settings and ensure the wazuh.updates.disabled is displayed and can be configured (try to save both possible values).
With wazuh.updates.disabled enabled (true), the UI related to check updates (bottom bar, data in Server APIs) should not appear.
With wazuh.updates.disabled disabled (false), the UI related to check updates (bottom bar, data in Server APIs) should appear (ensure you did not dismiss it).

Details

⚫ Go to Dashboard management > App Settings and ensure the wazuh.updates.disabled is displayed and can be configured (try to save both possible values).

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ With wazuh.updates.disabled enabled (true), the UI related to check updates (bottom bar, data in Server APIs) should not appear.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ With wazuh.updates.disabled disabled (false), the UI related to check updates (bottom bar, data in Server APIs) should appear (ensure you did not dismiss it).

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Desvelao Desvelao self-assigned this Nov 14, 2024
@Desvelao Desvelao linked an issue Nov 14, 2024 that may be closed by this pull request
2 tasks
@Desvelao Desvelao marked this pull request as ready for review November 14, 2024 15:09
@Desvelao Desvelao requested a review from a team November 14, 2024 15:39
@Machi3mfl Machi3mfl self-requested a review November 14, 2024 16:14
asteriscos
asteriscos previously approved these changes Nov 14, 2024
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Chrome Firefox Safari
Go to Dashboard management > App Settings and ensure the wazuh.updates.disabled is displayed and can be configured (try to save both possible values). 🟢 🟢
With wazuh.updates.disabled enabled (true), the UI related to check updates (bottom bar, data in Server APIs) should not appear. 🟢 🟢
With wazuh.updates.disabled disabled (false), the UI related to check updates (bottom bar, data in Server APIs) should appear (ensure you did not dismiss it). 🟢 🟢

Chrome 🟢

Peek.2024-11-14.17-10.mp4

Firefox 🟢

Peek.2024-11-14.17-16.mp4

@Machi3mfl
Copy link
Member

Machi3mfl commented Nov 14, 2024

Test

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
Go to Dashboard management > App Settings and ensure the wazuh.updates.disabled is displayed and can be configured (try to save both possible values). 🟢 🟢
With wazuh.updates.disabled enabled (true), the UI related to check updates (bottom bar, data in Server APIs) should not appear. 🟢 🟢
With wazuh.updates.disabled disabled (false), the UI related to check updates (bottom bar, data in Server APIs) should appear (ensure you did not dismiss it). 🟢 🟢

Details

Chrome

Screen.Recording.2024-11-14.at.1.32.51.PM.mov

Safari

Screen.Recording.2024-11-14.at.1.33.57.PM.mov

Machi3mfl
Machi3mfl previously approved these changes Nov 14, 2024
@asteriscos asteriscos dismissed stale reviews from Machi3mfl and themself via 4bb1a60 November 14, 2024 16:39
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.5% ( 400 / 879 )
Branches 41.09% ( 157 / 382 )
Functions 43.87% ( 136 / 310 )
Lines 45.69% ( 398 / 871 )

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 14.91% ( 4436 / 29749 )
Branches 9.79% ( 1886 / 19246 )
Functions 14.69% ( 1056 / 7185 )
Lines 15.12% ( 4330 / 28622 )

@asteriscos asteriscos merged commit dd12151 into 4.10.0 Nov 14, 2024
5 checks passed
@asteriscos asteriscos deleted the enhancement/7152-allow-edit-wazuh-updates-disabled-setting-from-ui branch November 14, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add control to disable checking for updates in the app settings
3 participants