Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for community plugins services listing #110

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add support for community plugins services listing #110

wants to merge 1 commit into from

Conversation

sboily
Copy link
Contributor

@sboily sboily commented May 26, 2021 •
edited by fblackburn1
Loading

This PR add new tab for list community plugins services

Currently the service is not yet ready but is coming soon.

Screen Shot 2021-05-25 at 8 19 15 PM

Screen Shot 2021-05-25 at 8 19 38 PM

@sboily sboily requested a review from fblackburn1 May 26, 2021 00:20
@wazo-community-zuul
Copy link
Contributor

Build failed.

@wazo-community-zuul
Copy link
Contributor

Build failed.

@fblackburn1
Copy link
Member

fblackburn1 commented Jun 1, 2021 •
edited
Loading

Do you have a valid url to test?

@fblackburn1 fblackburn1 marked this pull request as ready for review June 1, 2021 17:43
@fblackburn1
Copy link
Member

fblackburn1 commented Jun 1, 2021 •
edited
Loading

Oh I switch this PR from draft to ready-for-review, but maybe your "request me as reviewer" was not for this purpose?
Do you want to wait before merging to master?

@sboily
Copy link
Contributor Author

sboily commented Jun 1, 2021

Oh I switch this PR from draft to ready-for-review, but maybe your "request me as reviewer" was not for this purpose?
Do you want to wait before merging to master?

:) no problem, i propose to discuss by phone.

@wazo-community-zuul
Copy link
Contributor

Build failed.

@fblackburn1
Copy link
Member

recheck

@wazo-community-zuul
Copy link
Contributor

Build succeeded.

@fblackburn1
Copy link
Member

:) no problem, i propose to discuss by phone.

I don't remember what we said ... 😅
Do you remember?

@sboily
Copy link
Contributor Author

sboily commented Aug 17, 2021

:) no problem, i propose to discuss by phone.

I don't remember what we said ... 😅
Do you remember?

nope lol :). But this PR have two changes, one to change the UI for plugins and second to add a feature for having a community plugins based on github backend.

@wazo-community-zuul
Copy link
Contributor

Build succeeded.

@fblackburn1 fblackburn1 force-pushed the add_plugin_community branch 2 times, most recently from 9c6a422 to 309e988 Compare August 17, 2021 17:11
@wazo-community-zuul
Copy link
Contributor

Build succeeded.

@fblackburn1 fblackburn1 mentioned this pull request Aug 17, 2021
Merged
@fblackburn1 fblackburn1 changed the base branch from master to rework-plugin-layout August 17, 2021 17:26
@fblackburn1
Copy link
Member

fblackburn1 commented Aug 17, 2021 •
edited
Loading

I moved improvement of plugin box layout to #110
Now this PR only contains community plugins feature

@fblackburn1 fblackburn1 marked this pull request as draft August 17, 2021 17:31
@wazo-community-zuul
Copy link
Contributor

Build succeeded.

@fblackburn1
Copy link
Member

TODO
service to extract plugins need to be productized (i.e. added to our infrastructure and maintained with tests)

Base automatically changed from rework-plugin-layout to master August 17, 2021 17:36
@wazo-community-zuul
Copy link
Contributor

Build succeeded.

@wazo-community-zuul
Copy link
Contributor

Build succeeded.

@wazo-community-zuul
Copy link
Contributor

Build succeeded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fblackburn1 fblackburn1 Awaiting requested review from fblackburn1

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sboily @fblackburn1