Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements: use digium release for swagger-py #254

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fblackburn1
Copy link
Member

why: A commit to support Python 3 has been accepted in upstream repo in
2019. But no version has been released

why: A commit to support Python 3 has been accepted in upstream repo in
2019. But no version has been released
@sonarcloud
Copy link

sonarcloud bot commented Feb 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@wazo-community-zuul
Copy link
Contributor

Build failed.

@fblackburn1
Copy link
Member Author

fblackburn1 commented Feb 28, 2023

Too bad ...
I won't have time to investigate now

@fblackburn1 fblackburn1 marked this pull request as draft February 28, 2023 17:02
@sopelj
Copy link

sopelj commented Feb 28, 2023

Too bad ... I won't have time now to investigate

It looks like they merged some fixes for Python3 into master, but clearly there was a merge issue and in master there is still a Python2 import right below the try catch for dual compatibility:

https://github.com/digium/swagger-py/blob/6e7f6b9a0558b5220d205ff00de731f1fef252e8/swaggerpy/swagger_model.py#L14

So, we can't import from that file without patching it.

@sduthil
Copy link
Member

sduthil commented Mar 8, 2023

recheck

@wazo-community-zuul
Copy link
Contributor

Build failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants