-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pad the target when aligning #312
Open
ekg
wants to merge
59
commits into
main
Choose a base branch
from
target-pad
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses several compilation errors in the wflign module: - Removed nested namespace in wflign_swizzle.hpp - Added missing function definitions for try_swap_start_pattern and try_swap_end_pattern - Added using namespace directive to resolve type resolution issues - Corrected namespace closure and function implementations
This commit introduces: 1. CIGAR string conversion utilities in `wflign_cigar_utils.hpp` 2. Enhanced indel-swizzling logic in `do_biwfa_alignment` 3. Debug logging for chain and CIGAR processing 4. Coordinate updates based on swizzled CIGAR Key changes: - Convert WFA edit_cigar to/from string format - Apply swizzling only for internal chain chunks - Update alignment coordinates when CIGAR changes - Add detailed debug logging Remaining tasks: - Add boundary validation - Comprehensive testing - Optional configuration for swizzling behavior
…ing and boundary checks
feat: Add detailed sequence debug output for swizzle pattern matching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes so far:
A new parameter
target_padding
was added to theParameters
struct inalign_parameters.hpp
. This parameter adds additional padding around target sequences.In
computeAlignments.hpp
, the main changes are:parseMashmapRow
function to accept a newtarget_padding
parameterIn
parse_args.hpp
, added command-line support for the target padding feature:-E
or--target-padding
to specify padding around target sequenceObjectives:
-P 50k
for instance) and not at the starts and ends of chains. This would mean integrating a new bit of information into the mapping records to say where we are in the chain in addition to which chain id we have. We could stash that in a single variable or put multiple ones on the row (three are needed—chain id, chain length, position in chain).