Update tsconfig.json validation messages #2322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Martinsos
approved these changes
Oct 17, 2024
| type FieldPath = [String] | ||
|
|
||
| instance Show FullyQualifiedFieldName where | ||
| show (FieldName fieldPath) = show $ intercalate "." fieldPath |
There was a problem hiding this comment.
Suggested change
| show (FieldName fieldPath) = show $ intercalate "." fieldPath | |
| show (FieldName fieldPath) = intercalate "." fieldPath |
I think this extra show was redundant -> intercalate will already return a string in this case!
If you do wnat to have extra set of quotes around it, I would that below in the place of call, not add them here with show. Although I guess it was just a leftover.
Martinsos
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't output the fully qualified field name for the missing error message e.g. we sad "module" is missing vs. "compilerOptions.module" is missing.
This is maybe a bit over engineered, but I thought it looked nicely expressed with the type.