Merge with upstream #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[automatically-tag-and-release-this-commit] Co-authored-by: Auto Release Process <[email protected]>
…es (bytecodealliance#919) * test(*): hardening codegen tests by adding wasi proposals as submodules this commit adds a few git submodules for wasi proposals and placed them in `tests/codegen` folder for testing purposes. it also changes the structure now that it requires wit packages to have a `wit` folder inside the directory similar to how wasi proposal structures. Signed-off-by: Jiaxiao Zhou (Mossaka) <[email protected]> * test(rust): skip wasi-http and wasi-cli both have multiple worlds which require another refactoring of the current test codebase to adopt that Signed-off-by: Jiaxiao Zhou (Mossaka) <[email protected]> * test(*): skip wasi-* tests on teavm and csharp Signed-off-by: Jiaxiao Zhou (Mossaka) <[email protected]> --------- Signed-off-by: Jiaxiao Zhou (Mossaka) <[email protected]>
adds a command to initialize the Go directory and repalces Pirnt to HostPrint Signed-off-by: Jiaxiao Zhou (Mossaka) <[email protected]>
…nce#922) (bytecodealliance#926) Signed-off-by: Bob Aman <[email protected]>
…codealliance#925) Signed-off-by: Jiaxiao Zhou (Mossaka) <[email protected]>
…on (bytecodealliance#928) * Use a unique name for `libwit_bindgen_cabi_realloc.a` per-crate-version This commit updates how the weak `cabi_realloc` symbol is linked. Previously rustc was told to use `-lwit_bindgen_cabi_realloc` with a `-L` pointing to the source directory of the crate which has a precompiled copy. This caused issues, however, when two versions were present in a crate graph but only one was used. With two versions present in a crate graph rustc would use two `-L` flags with directories that both contain the same-named library. Which one was picked depended on the order that rustc passed flags. If only one crate was used, however, then rustc would not pass the rlib for the other crate. This could end up in a situation where with two wit-bindgen versions A and B: * During linking, A's `libwit_bindgen_cabi_realloc.a` file was used. * Rustc only passed B's rlib since A wasn't actually used anywhere. * The linker then tried to load A's version of the actual cabi_realloc symbol, but only B's was present. The fix in this commit is to uniquely name the library name based on the crate version. This matches how the symbol name is different per crate version, for example. * Remove copy/paste
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.