[PR] People record editing #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
April 12, 2017 15:13
This is super basic - just want to get it commited before making more substantial changes.
This might be madness, but it seemed like the right course yesterday afternoon, so I'm going to stick to it. The code in `admin-edit-profile-secondary.js` is only needed on sites other than the primary directory - even though some of its functions are referenced in `admin-edit-profile.js`. But, those functions will only be called on sites other than the primary directory. I've occasionally seen an error where the script is trying to `setContent` for the editors before TinyMCE is initialized, which informed the decision to enqueue `admin-edit-profile-secondary.js` from within `wp_enqueue_editor`. I haven't seen it since, so I'm hoping this has made it more reliable. The `secondary` script checks for changes before posting back to people.wsu.edu. This is probably overkill, but it seemed like a good idea at the time. Lastly, this is the start of an effort to (re)name JavaScript files in a way that better indicates where they're used.
I've been horribly inconsistent with my syntax in the JavaScript for this plugin, so this is an attempt to start rectifying that.
This is pretty bad, but it gets the general idea across. Even if a user doesn't have sufficient permissions to edit a profile, they should still be able to select which Working Title, Biography, and Photo to display on the front end for their particular site. So, this demonstrates how that could work - though I'm sure there's a nicer way to do it. Like one that doesn't throw a console error. I'm also wondering if doing it the other way around would make more sense (that is, disable all fields by default and only enable them if a user has permissions to edit the profile).
|
@jeremyfelt #reviewmerge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More work on #55. I think this gets us nearly there - a better way to handle the permissions checking and an indication that changes will be pushed back to
people.wsu.edumight be all we need to close the issue.