Add support for int8/16 to parquet encode #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| case int16: | ||
| field.SetFloat(float64(v)) | ||
| case int32: | ||
| field.SetFloat(float64(v)) | ||
| case int64: | ||
| field.SetFloat(float64(v)) |
There was a problem hiding this comment.
definitely lossy, but wont underflow/overflow
| case float32: | ||
| field.SetFloat(float64(v)) | ||
| case float64: | ||
| field.SetFloat(v) |
There was a problem hiding this comment.
Is this lossy? Or is the float32 field just stored as float64
There was a problem hiding this comment.
I think so, but would have to be a humongous number. We can fix this later if it comes up, thats how it worked before
arjunnair1997
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.