add: log all errors wrapper for Logger component #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardartoul
approved these changes
Oct 29, 2024
internal/log/strict.go
Outdated
| continue | ||
| } | ||
|
|
||
| switch arg.(type) { |
There was a problem hiding this comment.
I think you probably want something like this:
_, isErr := arg.(error)instead to see if it implements the error interface, not if its literally an error no?
There was a problem hiding this comment.
Wont the switch case also check if the value arg implements the error interface?
Or are you suggesting we remove the check for *error as well since that's technically not an error type.
There was a problem hiding this comment.
I guess if your tests pass its fine
internal/log/config.go
Outdated
| @@ -14,13 +14,15 @@ const ( | |||
| fieldFilePath = "path" | |||
| fieldFileRotate = "rotate" | |||
| fieldFileRotateMaxAge = "rotate_max_age_days" | |||
| fieldStrictLogging = "strict" | |||
There was a problem hiding this comment.
log_all_errors IMO instead of "strict" since thats way more clear
There was a problem hiding this comment.
Update all the variables / go code to match the name as well
gregfurman
changed the title
richardartoul
approved these changes
Oct 30, 2024
richardartoul
approved these changes
Oct 30, 2024
|
I acknowledge the request for review - will give it a good look soon 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an optional wrapped logger that will promote any log with an
errortype to theERRORlevel.This does not include ading an error in a logger's
WithorWithField.For example, if you set:
Then any subsequent
loggercallingWarn,Info,Debug,Trace, or with anerrortype in the params will promote the log to anErrortype.In addition, a field
@log_all_errors=trueis added to all logs generated from the strict logger: