Fix merge issue503 #505
Open
Fix merge issue503 #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter merge) fixes issue 503
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #503 contains two unrelated problems.
The parallelisation of the plot routine for generating xsf files was broken after a later merge that affected how the k-point distribution is handled (passed as an argument instead of being regenerated locally). This is corrected with a simple cycle condition and passing the k-distribution list.
A second, earlier commit that applied the ws_distance method to postw90 (mirroring its use in hamiltonian.F90) was apparently reverted in entirety (see discussion in issue #503 ); it is fixed by replaying those changes and merging.