Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize github pages #485

Closed
wants to merge 6 commits into from

Conversation

qiaojunfeng
Copy link
Collaborator

Some commits to bootstrap the docs versioning.

Once this is merged, docs will be automatically deployed using github actions in #484, whenever there is a new release (e.g. v4.0.0) on github.

This is draft since I need to rebase the PR after the merge of #484.

@qiaojunfeng qiaojunfeng added this to the v4.0 milestone Feb 17, 2024
@qiaojunfeng qiaojunfeng marked this pull request as draft February 17, 2024 22:20
@LecrisUT
Copy link
Contributor

RTD supports mkdocs 1. I highly recommend not to go with GH-pages and instead use RTD. If there are any concerns I am happy to discuss them.

@giovannipizzi @qiaojunfeng

Footnotes

  1. https://docs.readthedocs.io/en/stable/config-file/v2.html

@qiaojunfeng
Copy link
Collaborator Author

RTD supports mkdocs 1. I highly recommend not to go with GH-pages and instead use RTD. If there are any concerns I am happy to discuss them.

@giovannipizzi @qiaojunfeng

Footnotes

  1. https://docs.readthedocs.io/en/stable/config-file/v2.html

RTD is OK, it's just I don't want to see advertisements on the doc webpages. I think for the free version, we cannot git rid of ads.

Could you explain in detail the downsides of gh-pages than RTD? If RTD is much better in terms of some features, I can try RTD and see if people can tolerate the ads.

@LecrisUT
Copy link
Contributor

Thanks for sharing the concerns

RTD is OK, it's just I don't want to see advertisements on the doc webpages

This is disableable, here is the instructions:
Screenshot_20240222_100948

The gold membership is 5$/month.

Could you explain in detail the downsides of gh-pages than RTD? If RTD is much better in terms of some features, I can try RTD and see if people can tolerate the ads.

  • RTD supports versioning automatically, including adding/removing versions
  • Visibility and SEO
  • RTD can be run on pull requests
  • Reduced maintenance, e.g. python versioning and guaranteeing compatibility
  • RTD adds additional default options to optimize search and other things we should not think about
  • Some projects can use RTD API to display pop-up displays of cross-projects, and other nice features
  • GH-pages, will get messy for git cloning

@qiaojunfeng
Copy link
Collaborator Author

Thanks for the info!

  • RTD supports versioning automatically, including adding/removing versions

Yes, that's one advantage, with gh-pages I need to use mike to do the versioning for mkdocs, which is also quite nice but we need to store them in the gh-pages branch.

  • Visibility and SEO
  • RTD adds additional default options to optimize search and other things we should not think about

I have some other projects that are using gh-pages, and they can be indexed as the topmost one by google/bing/duckduckgo in few days. For a much more widely used repo like wannier90, I wouldn't worry too much.

  • RTD can be run on pull requests

This is nice to have.

  • Reduced maintenance, e.g. python versioning and guaranteeing compatibility

I am using GitHub workflows for docs deployment upon each wannier90 release, so both are fine.

  • Some projects can use RTD API to display pop-up displays of cross-projects, and other nice features

OK.

  • GH-pages, will get messy for git cloning

Indeed this is the biggest disadvantage of gh-pages, for now all the html+js are around 7.8MB for each release. This will increase the size of the repo in the long term.

So in the end it's weather we want to remove ads or reduce the size of the repo.

I will create a test doc on RTD to see it in real, then we decide which one we want.

qiaojunfeng added a commit to qiaojunfeng/wannier90 that referenced this pull request Feb 22, 2024
- Add version warning
- Auto deploy docs to `gh-pages` on github release

The commit is kept here as a reference.

We will switch to readthedocs to deploy multiple versions of the docs,
since mike use `gh-pages` branch to host the docs, increasing the size
of the repo in the long term. See wannier-developers#485 for more details.
qiaojunfeng added a commit to qiaojunfeng/wannier90 that referenced this pull request Feb 27, 2024
- Add version warning
- Auto deploy docs to `gh-pages` on github release

The commit is kept here as a reference.

We will switch to readthedocs to deploy multiple versions of the docs,
since mike use `gh-pages` branch to host the docs, increasing the size
of the repo in the long term. See wannier-developers#485 for more details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants