[ubuntu] add aws ami source #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jojand
commented
Dec 13, 2023
jojand
commented
Dec 13, 2023
jojand
commented
Dec 13, 2023
| @@ -170,8 +245,52 @@ source "azure-arm" "build_image" { | |||
| } | |||
| } | |||
|
|
|||
| source "amazon-ebs" "ubuntu-base-2204" { | |||
There was a problem hiding this comment.
new source for aws ami source
jojand
commented
Dec 13, 2023
| build { | ||
| sources = ["source.azure-arm.build_image"] | ||
| sources = var.sources |
There was a problem hiding this comment.
input as variable with default value for backward compatibility reasons
azure is always build as default if no sources variable is provided
jojand
commented
Dec 13, 2023
| @@ -138,6 +138,81 @@ variable "vm_size" { | |||
| default = "Standard_D4s_v4" | |||
| } | |||
|
|
|||
| variable "sources" { | |||
| type = list(string) | |||
| default = ["source.azure-arm.build_image"] | |||
There was a problem hiding this comment.
input as variable with default value for backward compatibility reasons
azure is always build as default if no sources variable is provided
jojand
force-pushed
the
add-ami-support
branch
2 times, most recently
from
7f820d6
to
2ff6585
Compare
jojand
force-pushed
the
add-ami-support
branch
from
2ff6585
to
ece5d40
Compare
ostefek99
requested changes
Jan 4, 2024
|
And please use |
ostefek99
requested changes
Jan 4, 2024
jojand
force-pushed
the
add-ami-support
branch
from
ece5d40
to
1ae5683
Compare
applied for my changes |
jojand
force-pushed
the
add-ami-support
branch
from
4fe8d1e
to
0b01aca
Compare
ostefek99
requested changes
Jan 9, 2024
ostefek99
previously approved these changes
Jan 9, 2024
jojand
force-pushed
the
add-ami-support
branch
from
34dac07
to
bde99b2
Compare
juldou
force-pushed
the
add-ami-support
branch
from
24c64a6
to
918e50d
Compare
jizi
force-pushed
the
add-ami-support
branch
2 times, most recently
from
a6f3337
to
d2d7da4
Compare
jizi
force-pushed
the
add-ami-support
branch
2 times, most recently
from
e7f8bd4
to
599286c
Compare
deynekas
force-pushed
the
add-ami-support
branch
from
f7aac0e
to
f0b08b0
Compare
jojand
force-pushed
the
add-ami-support
branch
3 times, most recently
from
d67b4b4
to
ef70640
Compare
jizi
force-pushed
the
add-ami-support
branch
2 times, most recently
from
be13ab6
to
1058c9b
Compare
deynekas
force-pushed
the
add-ami-support
branch
from
1058c9b
to
973e98c
Compare
deynekas
force-pushed
the
add-ami-support
branch
from
973e98c
to
8c35ca4
Compare
…ment-azure-arm.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New tool, Bug fixing, or Improvement?
Please include a summary of the change and which issue is fixed. Also include relevant motivation and context.
For new tools, please provide total size and installation time.
Related issue:
Check list