Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo #3846

Merged
merged 4 commits into from
Nov 7, 2024
Merged

Fixed typo #3846

merged 4 commits into from
Nov 7, 2024

Conversation

takuyahara
Copy link
Contributor

@takuyahara takuyahara commented Oct 22, 2024

- - Uploading to platforms like S3, Supbase, etc.
+ - Uploading to platforms like S3, Supabase, etc.

Summary by CodeRabbit

  • Documentation
    • Updated guidance on building Wails projects for multiple platforms using GitHub Actions.
    • Added details on creating separate builds for Linux, Windows, and macOS.
    • Included a YAML configuration example for the build process and environment variable management.
    • Corrected a minor textual error from "Supbase" to "Supabase."
  • New Features
    • Added the option to set a window class name on Windows.
    • Specified macOS minimum version externally.
  • Bug Fixes
    • Resolved cross-compilation issues with CGO.
    • Addressed a native webview2loader issue.
    • Corrected an example for the macOS menu.

Copy link
Contributor

coderabbitai bot commented Oct 22, 2024

Walkthrough

The documentation for building Wails projects across multiple platforms using GitHub Actions has been updated. It now includes an introduction that stresses the need for separate builds for each operating system and details a specific GitHub Action for this task. The example workflow triggers on new Git tags and includes a YAML configuration for Linux, Windows, and macOS builds. It also addresses potential out-of-memory issues and employs a fail-fast strategy for concurrent job execution. A minor correction was made in the enhancements list, changing "Supbase" to "Supabase."

Changes

File Path Change Summary
website/docs/guides/crossplatform-build.mdx Updated to include guidance on multi-platform builds using GitHub Actions, example YAML configuration, and minor textual correction from "Supbase" to "Supabase."
website/src/pages/changelog.mdx Updated changelog to reflect new features, bug fixes, and modifications, including setting window class name on Windows and external macOS minimum version specification.

Possibly related PRs

Suggested reviewers

  • leaanthony

Poem

In the garden where builds do play,
Wails hops across platforms today.
With GitHub Actions, swift and bright,
Each tag brings a build, a joyful sight!
No more OOM, just code in flight,
Supabase shines, everything's right! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 5177108 and f783f4d.

📒 Files selected for processing (1)
  • website/src/pages/changelog.mdx (1 hunks)
🔇 Additional comments (1)
website/src/pages/changelog.mdx (1)

23-23: LGTM: Typo fix from "Supbase" to "Supabase"

The correction of the platform name from "Supbase" to "Supabase" improves documentation accuracy.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@takuyahara takuyahara mentioned this pull request Oct 22, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
website/docs/guides/crossplatform-build.mdx (1)

63-63: LGTM! Consider adding a brief explanation of Supabase.

The typo has been correctly fixed from "Supbase" to "Supabase". This change improves the accuracy of the documentation.

As a minor enhancement, consider adding a brief explanation or link to Supabase, as some readers might not be familiar with this platform. For example:

-- Uploading to platforms like S3, Supabase, etc.
+- Uploading to platforms like S3, Supabase (an open source Firebase alternative), etc.
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 5ebccf1 and 5177108.

📒 Files selected for processing (1)
  • website/docs/guides/crossplatform-build.mdx (1 hunks)
🧰 Additional context used

Copy link

sonarcloud bot commented Nov 6, 2024

@leaanthony leaanthony merged commit d1ba26a into wailsapp:master Nov 7, 2024
12 checks passed
@takuyahara takuyahara deleted the patch-3 branch November 7, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants