-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v3] Added AppDataDirectory path #3823
Merged
leaanthony
merged 10 commits into
wailsapp:v3-alpha
from
ansxuman:feature/v3-add-appdata-path-to-runtime
Nov 16, 2024
+193
−5
Merged
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a4ffb6a
Added appData
ansxuman e6bf6d8
Updated changelog
ansxuman 216cd09
Updated doc and added error handling and fallbacks
ansxuman 9e12aac
Updated doc
ansxuman 5a0b492
Expose XDG methods
ansxuman afb8385
Merge branch 'v3-alpha' into feature/v3-add-appdata-path-to-runtime
leaanthony 129592d
Merge branch 'v3-alpha' into feature/v3-add-appdata-path-to-runtime
ansxuman 8167044
Refactor Path method. Add Paths method
leaanthony 8fd415f
Fix changelog
leaanthony 6c3f442
Merge branch 'v3-alpha' into feature/v3-add-appdata-path-to-runtime
leaanthony File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simplify and correct user configuration path retrieval
The
getUserConfigPath
function includes complex logic involvingxdg.ConfigDirs
to determine the user configuration directory. On macOS, configuration files are typically stored in~/Library/Preferences
. The usage ofxdg.ConfigDirs
may not be necessary and could introduce unexpected behavior.Consider simplifying the function to directly return the macOS preferences directory:
If there's a need to handle user-defined configuration directories, ensure that the logic accurately reflects macOS directory structures and standards.
📝 Committable suggestion