add thread:setname and thread:getname #208
Conversation
|
Is Some quick googling suggests:
|
src/thread.c
Outdated
| } | ||
| lua_pushstring(L, buf); | ||
| return 1; | ||
| } /* ct_setname() */ |
|
Oh, you're right, that's quite a mess. I've added checks to explicitly support the relevant functions on Linux, the BSDs and OS X. |
There was a problem hiding this comment.
Note that config.h.guess is from the autoguess project (https://github.com/wahern/autoguess/).
You may want to send your changes there?
config.h.guess
Outdated
| #endif | ||
|
|
||
| #ifndef HAVE_NETBSD_PTHREAD | ||
| //5.0.0 has setname() but no getname(). let's not support it for now. |
| @@ -853,5 +853,33 @@ | |||
| #define STRERROR_R_CHAR_P ((AG_GLIBC_PREREQ(0,0) || AG_UCLIBC_PREREQ(0,0,0)) && (HAVE__GNU_SOURCE || !(_POSIX_C_SOURCE >= 200112L || _XOPEN_SOURCE >= 600))) | |||
| #endif | |||
|
|
|||
| #ifndef HAVE_GLIBC_PTHREAD | |||
There was a problem hiding this comment.
The define is only really about pthread_setname, please rename them all accordingly
There was a problem hiding this comment.
Different pthread implementations have different function signatures, and some only have setname and no getname. That's why I've introduced the HAVE_<PLATFORM>_PTHREAD macro as welll as HAVE_PTHREAD_SETNAME and HAVE_PTHREAD_GETNAME.
There was a problem hiding this comment.
I don't think that really makes sense though: the values you've chosen here are very geared to the setname call.
e.g. glibc had pthreads long before 2.12.
There was a problem hiding this comment.
true -- i'll use some other name then
| #if HAVE_PTHREAD_SETNAME | ||
| static int ct_setname(lua_State *L) { | ||
| struct cthread *ct = ct_checkthread(L, 1); | ||
| char *name = luaL_checkstring(L, 2); |
There was a problem hiding this comment.
there is too much whitespace here.
src/thread.c
Outdated
| rc = pthread_setname_np(ct->id, "%s", name); | ||
| #elif (HAVE_FREEBSD_PTHREAD || HAVE_OPENBSD_PTHREAD) | ||
| rc = 0; | ||
| // from FreeBSD & OpenBSD man page: |
There was a problem hiding this comment.
Use /**/ instead of //
| #elif HAVE_MACOSX_PTHREAD | ||
| if (pthread_equal(ct->id, pthread_self())) { | ||
| lua_pushboolean(L, 0); | ||
| lua_pushliteral(L, "thread name cannot be set from outside the thread on this platform"); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
src/thread.c
Outdated
| case ERANGE: | ||
| lua_pushboolean(L, 0); | ||
| lua_pushliteral(L, "thread name too long"); | ||
| return 2; |
There was a problem hiding this comment.
cqueues returns false, message, errno on failure (or just false, errno).
Adds wrappers for
pthread_setname_npandpthread_getname_npto the thread metatable. It's quite useful to be able to name long-running threads!