Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some small code cleanups #172

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

daurnimator
Copy link
Collaborator

@daurnimator daurnimator commented Nov 14, 2016

  • In :checktls() the inner code previously redeclared the same locals, shadowing the upvalues.
  • TLS 'pushback' data wasn't freed until the whole socket object was. free() it after it has been read.

The inner code previously redeclared the same locals, shadowing the upvalues.

This commit takes out the redundant code rather than removing the shadowing declaration as I'd like to support installing luaossl while a long-running cqueues program is running and have it automatically picked up.
@daurnimator daurnimator changed the title src/socket.lua: Remove dead code in socket:checktls() Some small code cleanups Nov 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant