Skip to content

Commit

Permalink
update after NOTEs on CRAN
Browse files Browse the repository at this point in the history
  • Loading branch information
wahani committed Dec 19, 2015
1 parent dac0d64 commit 76905d1
Show file tree
Hide file tree
Showing 3 changed files with 34 additions and 10 deletions.
24 changes: 15 additions & 9 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
title: "Modules in R"
author: "Sebastian Warnholz"
date: "2015-12-18"
date: "2015-12-19"
output: rmarkdown::html_vignette
vignette: >
%\VignetteIndexEntry{Modules in R}
Expand All @@ -11,7 +11,7 @@ vignette: >

[![Build Status](https://travis-ci.org/wahani/modules.png?branch=master)](https://travis-ci.org/wahani/modules)
[![codecov.io](https://codecov.io/github/wahani/modules/coverage.svg?branch=master)](https://codecov.io/github/wahani/modules?branch=master)
[![CRAN](http://www.r-pkg.org/badges/version/modules)](https://cran.rstudio.com/package=modules)
[![CRAN](http://www.r-pkg.org/badges/version/modules)](https://cran.r-project.org/package=modules)
[![Downloads](http://cranlogs.r-pkg.org/badges/modules?color=brightgreen)](http://www.r-pkg.org/pkg/modules)

Provides modules as an organizational unit for source code. Modules enforce to be more rigorous when defining dependencies and have a local search path. They can be used as a sub unit within packages or in scripts.
Expand Down Expand Up @@ -48,6 +48,13 @@ Typically you do not have to call that function explicitly but instead call

```r
library(modules)
```

```
## Loading required package: aoos
```

```r
m <- module({
boringFunction <- function() cat("boring output")
})
Expand Down Expand Up @@ -235,12 +242,11 @@ search()
```

```
## [1] ".GlobalEnv" "import:module" "import:module"
## [4] "import:module" "package:parallel" "package:modules"
## [7] "package:aoos" "tools:rstudio" "package:stats"
## [10] "package:graphics" "package:grDevices" "package:utils"
## [13] "package:datasets" "package:methods" "Autoloads"
## [16] "package:base"
## [1] ".GlobalEnv" "import:module" "package:parallel"
## [4] "package:modules" "package:aoos" "tools:rstudio"
## [7] "package:stats" "package:graphics" "package:grDevices"
## [10] "package:utils" "package:datasets" "package:methods"
## [13] "Autoloads" "package:base"
```

```r
Expand Down Expand Up @@ -319,7 +325,7 @@ clusterMap(cl, m$gen, list(m$NewType(NULL)))
## NULL
##
## attr(,".self")
## <environment: 0x324db20>
## <environment: 0x4d0ac30>
## attr(,"class")
## [1] "NewType" "list"
```
Expand Down
18 changes: 18 additions & 0 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@

This is a re-submission of the package, as requested. The reason for the new
submission was the following NOTE in the previous version:

Found the following (possibly) invalid URLs:
URL: http://www.r-pkg.org/pkg/modules
From: inst/doc/modulesInR.html
Status: 404
Message: Not Found
URL: https://cran.rstudio.com/package=modules
From: inst/doc/modulesInR.html
Status: 404
Message: Not Found

I resolved this by removing the badges from the vignette.

## Test environments
* ubuntu (on travis-ci), R 3.2.3
* win-builder (devel and release)
Expand All @@ -8,3 +24,5 @@ There were no ERRORs, WARNINGs or NOTEs

## Downstream dependencies
There are none, this is the first release.


2 changes: 1 addition & 1 deletion vignettes/modulesInR.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ vignette: >

[![Build Status](https://travis-ci.org/wahani/modules.png?branch=master)](https://travis-ci.org/wahani/modules)
[![codecov.io](https://codecov.io/github/wahani/modules/coverage.svg?branch=master)](https://codecov.io/github/wahani/modules?branch=master)
[![CRAN](http://www.r-pkg.org/badges/version/modules)](https://cran.rstudio.com/package=modules)
[![CRAN](http://www.r-pkg.org/badges/version/modules)](https://cran.r-project.org/package=modules)
[![Downloads](http://cranlogs.r-pkg.org/badges/modules?color=brightgreen)](http://www.r-pkg.org/pkg/modules)

```{r, results='asis', echo=FALSE}
Expand Down

0 comments on commit 76905d1

Please sign in to comment.