선호학과 정보 저장 #366
Open
선호학과 정보 저장 #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
plgafhd
commented
Oct 10, 2024
plgafhd
commented
- 사실 최근 검색 학과 저장 (5개 저장)
- 필터 바텀시트에서 학과 목록을 보여줄 때 별도의 맨 위 항목으로 뜨게 됨
- 최근 검색 기록은 로컬 저장 (로그아웃 하면 초기화)
plgafhd
commented
Oct 10, 2024
Comment on lines
172
to
177
| ) | ||
| closeBottomSheetPlaceable.placeRelative( | ||
| tagTypePlaceable.width + tagListPlaceable.width - 52, | ||
| (SearchOptionSheetConstants.TopMargin.toPx().roundToInt() - 32) / 2, | ||
| ) | ||
| if (baseAnimatedFloat.value != 0f) dragSheetPlaceable.placeRelative(0, 0) |
There was a problem hiding this comment.
얘는 뭐냐면... 그 피그마에 보면 필터 바텀시트 상단에 X 버튼이 있는데, 원래 없었길래 추가하려 했는데
왜인지 모르게 사진처럼 오른쪽으로 쏠려서 나와... 코드에서 이상한 점을 못찾겠어
There was a problem hiding this comment.
-52를 한 이유는 아이콘 size 32 + padding 20
| @@ -66,6 +70,22 @@ class LectureSearchRepositoryImpl @Inject constructor( | |||
| return response.content | |||
| } | |||
|
|
|||
| override fun storeRecentSearchedDepartment(tag: TagDto) { | |||
| stoarge.recentSearchedDepartments.update( | |||
There was a problem hiding this comment.
stoarge -> storage 오타나있어
JuTaK97
reviewed
Oct 22, 2024
| @@ -23,4 +27,6 @@ interface LectureSearchRepository { | |||
| suspend fun getBuildings( | |||
| places: String, | |||
| ): List<LectureBuildingDto> | |||
|
|
|||
| fun storeRecentSearchedDepartment(tag: TagDto) | |||
There was a problem hiding this comment.
굳이 TagDto 를 저장할 이유가 있나? 어차피 TagType.DEPARTMENT 만 저장되는거면 학과 이름만 하는게 나을 것 같은데
There was a problem hiding this comment.
어차피 꺼낼 때 TagDto 형태로 꺼내서 UI 에 바로 넣는구나
상관없겠다
JuTaK97
reviewed
Oct 22, 2024
Comment on lines
+73
to
+81
| override fun storeRecentSearchedDepartment(tag: TagDto) { | ||
| storage.recentSearchedDepartments.update( | ||
| storage.recentSearchedDepartments.get().toMutableList().apply { | ||
| if (contains(tag)) remove(tag) | ||
| add(tag) | ||
| while (count() > 5) removeAt(0) | ||
| }, | ||
| ) | ||
| } |
There was a problem hiding this comment.
Suggested change
| override fun storeRecentSearchedDepartment(tag: TagDto) { | |
| storage.recentSearchedDepartments.update( | |
| storage.recentSearchedDepartments.get().toMutableList().apply { | |
| if (contains(tag)) remove(tag) | |
| add(tag) | |
| while (count() > 5) removeAt(0) | |
| }, | |
| ) | |
| } | |
| override fun storeRecentSearchedDepartment(tag: TagDto) { | |
| val previousStoredTags = storage.recentSearchedDepartments.get() | |
| if (tag in previousStoredTags) { | |
| storage.recentSearchedDepartments.update(previousStoredTags - tag) | |
| } else { | |
| storage.recentSearchedDepartments.update((previousStoredTags + tag).takeLast(5)) | |
| } | |
| } |
JuTaK97
reviewed
Oct 22, 2024
| tagsByTagType, recentSearchedDepartments, _selectedTags, | ||
| ) { tagsByTagType, recentDepartments, selectedTags -> | ||
| recentDepartments.filter { recentDepartment -> | ||
| tagsByTagType.map { tag -> tag.item }.contains(recentDepartment) |
There was a problem hiding this comment.
tagsByTagType.map { tag -> tag.item } 를 filter 내부 루프 돌면서 매번 계산하는데 살짝 개선해보자
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.