Updated dependencies, including TypeORM 0.3.10 #235
Conversation
erlendfh
force-pushed
the
update-dependencies
branch
2 times, most recently
from
024d3fd
to
29e50c2
Compare
erlendfh
force-pushed
the
update-dependencies
branch
from
29e50c2
to
a2e1669
Compare
src/entity-factory.ts
Outdated
| @@ -52,14 +51,15 @@ export class EntityFactory<Entity, Context> { | |||
| throw new Error(message) | |||
| } | |||
| } else { | |||
| console.warn('No db connection is given: ', dataSource.isInitialized, dataSource) | |||
There was a problem hiding this comment.
Should printWarning be used here instead?
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "compilerOptions": { | |||
| "lib": ["es5", "es6"], | |||
| "target": "es5", | |||
| "lib": ["dom", "es5", "es6"], | |||
There was a problem hiding this comment.
Why is the "dom" lib needed? Just asking out of curiousity.
There was a problem hiding this comment.
@MykleNero thanks for taking the time to look at this! The "dom" was just a quick fix for this error:
$ yarn build
yarn run v1.22.17
$ rimraf dist
$ tsc --project ./tsconfig.build.json
node_modules/@types/node/ts4.8/stream.d.ts:842:39 - error TS2304: Cannot find name 'Blob'.
842 static from(src: Stream | Blob | ArrayBuffer | string | Iterable<any> | AsyncIterable<any> | AsyncGeneratorFunction | Promise<any> | Object): Duplex;
~~~~
Found 1 error in node_modules/@types/node/ts4.8/stream.d.ts:842
Blob is defined as a global in the browser, but is a member of buffer in node. It's a little unclear to me what is dependent on stream, so adding "dom" to lib is the only workaround I've found so far.
erlendfh
force-pushed
the
update-dependencies
branch
from
812abea
to
dbf5c35
Compare
erlendfh
force-pushed
the
update-dependencies
branch
from
dbf5c35
to
e27c2b8
Compare
Agreed, would be great to get this in. |
|
Hello @erlendfh PR looks great and it seems this repo is not maintained anymore. Could you publish your version to NPM with a different name? I'd do it but since it's your work, better if you do that. |
No description provided.