Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recent History STF Test Vectors (GP Section 7) #11

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Recent History STF Test Vectors (GP Section 7) #11

wants to merge 10 commits into from

Conversation

davxy
Copy link
Contributor

@davxy davxy commented Aug 25, 2024 •
edited
Loading

README

  • ASN.1 schema
  • README
  • MMR computation using keccak-256
  • JAM Codec (*.bin files)
  • Delete *.scale vectors (old compact)

@davxy davxy marked this pull request as ready for review August 26, 2024 10:42
@xlc
Copy link
Contributor

xlc commented Aug 28, 2024 •
edited
Loading

I am not getting the same MMR hash. Can you clarify how it is calculated?
For progress_blocks_history-2, the payload is 0x8720b97ddd6acc0f6eb66e095524038675a4e4067adc10ec39939eaefc47d842 ++ 0x7507515a48439dc58bc318c48a120b656136699f42bfd2bd45473becba53462d and the hash I am getting is 0x 7076c31882a5953e097aef8378969945e72807c4705e53a0c5aacc9176f0d56b

The same hash can be reproduced with https://emn178.github.io/online-tools/keccak_256.html using input of 8720b97ddd6acc0f6eb66e095524038675a4e4067adc10ec39939eaefc47d8427507515a48439dc58bc318c48a120b656136699f42bfd2bd45473becba53462d

Could you share the preimage of the hashed value 0x0df4132e2561139036349d9f883109d15cabdba60a27d93d8b434302282cb9ca?

@xlc xlc mentioned this pull request Aug 28, 2024
Merged
@davxy
Copy link
Contributor Author

davxy commented Aug 28, 2024 •
edited
Loading

@xlc there was a deviation from the spec in our implementation. Thank you

@xlc
Copy link
Contributor

xlc commented Aug 28, 2024

the values are matching with our implementation now 👍

@davxy davxy mentioned this pull request Aug 30, 2024
Merged
2 tasks
@turuslan turuslan mentioned this pull request Sep 25, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davxy @xlc