Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Universaldot [Milestone 1] #5

Closed
wants to merge 3 commits into from

Conversation

stojanov-igor
Copy link

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, invoices must be submitted and payments will be transferred to the Polkadot account provided in the invoice.
  • The delivery is according to the rules of the JAM Prize.

Copy link

github-actions bot commented Oct 6, 2024

T&C Assistant Lite bot All Contributors have signed the T&Cs.
Posted by the CLA Assistant Lite bot.

@stojanov-igor
Copy link
Author

I have read and hereby sign the JAM Prize Terms and Conditions.

@anaelleltd anaelleltd added the invalid This doesn't seem right label Oct 7, 2024
@andresilva
Copy link

andresilva commented Oct 8, 2024

This doesn't seem to implement the jam spec in any way. There are some test vectors available (https://github.com/w3f/jamtestvectors), your implementation should be passing those.

Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stojanov-igor I will close the PR due to inactivity. Let me know if I should reopen it.

@Noc2
Copy link
Collaborator

Noc2 commented Nov 12, 2024

(see above)

@Noc2 Noc2 closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants