Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TuxedoDapp milestone 2 #1171

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

AltiMario
Copy link
Contributor

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, invoices must be submitted and payments will be transferred to the Polkadot AssetHub and/or fiat account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#2112

@PieWol PieWol self-assigned this Jul 23, 2024
@github-actions github-actions bot added the stale label Aug 7, 2024
@github-actions github-actions bot added to close and removed stale labels Aug 22, 2024
@PieWol PieWol removed the to close label Aug 22, 2024
@github-actions github-actions bot added the stale label Sep 6, 2024
@PieWol PieWol removed the stale label Sep 19, 2024
@PieWol
Copy link
Member

PieWol commented Oct 1, 2024

Hey @AltiMario ,
I'm looking forward to finally review this delivery. Is there anything you would like to change or fix beforehand? Just checking in as there were quite some changes to the first delivery after this one was put up. Let me know if the testing guide is complete and working.

@AltiMario
Copy link
Contributor Author

hi @PieWol thanks for your support. We managed to fix the frontend, however, a little tuning has to be done in the backend as well because the flag "not for selling" after a purchase doesn't reset. I believe it can be fixed this week and I will invite you for the (hopefully) final review asap.

@PieWol
Copy link
Member

PieWol commented Oct 1, 2024

Perfect, thank you!

@PieWol
Copy link
Member

PieWol commented Oct 13, 2024

Hey @AltiMario ,
any updates? :)

@AltiMario
Copy link
Contributor Author

hi, @PieWol, I think @NadigerAmit is going to share some information about it

@NadigerAmit
Copy link

NadigerAmit commented Oct 18, 2024

Hi @PieWol
cc: @AltiMario

I am sorry for the late reply.

The status of a kitty being "for sale" or not is determined by the blockchain logic. This information is stored as part of the transaction in the block, so the frontend does not control whether a kitty is for sale. The decision is based on whether the output kitty instance in the transaction is of type "Kitty piece" or "Tradable kitty piece."

Our original game design is as follows:

We categorized kitties into two types:
a. Kitty - These kitties are not for sale.
b. TradableKitty - These kitties are available for sale which as extra feild price.

When we want to sell a kitty, a "Kitty" is converted to a "TradableKitty" via the "List kitty for sale" process. Once a sale is completed, only the ownership of the kitty changes from the seller to the buyer, along with the transfer of funds. The type of the kitty remains "TradableKitty" even after the transaction.

If the new owner does not wish to sell the purchased kitty, they need to submit a separate transaction to convert the "TradableKitty piece" back to a regular "Kitty piece" using the delist_kitty_from_sale API.

Implementing a feature that automatically makes the purchased kitty "not for sale" would require changes to both the blockchain logic and the web service code. This would not be a straightforward modification and needs a significant effort.

Therefore, I recommend maintaining the current design and implementation at this point in time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants