Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Informative change to fix incorrect count of number of elements. #124

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

Wind4Greg
Copy link
Collaborator

@Wind4Greg Wind4Greg commented Jan 11, 2024

This PR addresses issue #120 regarding the number of elements involved with proof and verification processing. The names of the elements involved are correct the informative count of the number of those elements was not and is fixed by this PR.


Preview | Diff

Copy link
Contributor

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Note: We can either merge this as-is to address the immediately problem or we could add to it any other components we decided to include in the base proof, such as the publicKey -- since it will touch the same lines.

@Wind4Greg Wind4Greg requested a review from TallTed January 16, 2024 16:49
index.html Outdated Show resolved Hide resolved
@Wind4Greg Wind4Greg requested a review from davidlehn January 25, 2024 15:57
@Wind4Greg
Copy link
Collaborator Author

Editorial, multiple reviews, changes requested and made, no objections, merging.

@Wind4Greg Wind4Greg merged commit 70c312e into w3c:main Feb 5, 2024
2 checks passed
@Wind4Greg Wind4Greg deleted the fix-element-numbers branch February 5, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants