-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Navigation Menu Button test plan to V2 test format #996
Conversation
…o the V2 test format
…b.com/w3c/aria-at into tests/menu-button-navigation-refactor
@mcking65 this is ready for review. |
… next, previous, or by typing a character
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link text in the references for example is incorrect:
It is "APG Example: Actions Menu Button Using"
It should be: "APG Example: Navigation Menu Button"
In test 1 and test 2, step 3 in the instructions has an extra comma:
- Starting at the 'Navigate forwards from here' link,, navigate to the menu button.
In the following tests, Change assertion priority to 3 for "convey role of the focused item, 'menu item':
Test 4: Open a menu
Test 5: Open a menu to the last item
In Test 9: Navigate to an item in a menu by typing a character, The VoiceOver command "w" needs to specify the setting for single character quick nav off.
wow, I just realized that I was looking at the wrong test plan in preview! I was looking at action menu button. I'm relooking now. |
I revised my feedback after looking at the correct test plan ... it is very similar to what I previously posted. |
@mcking65 I’ve implemented the required changes. Tests 7, 8, and 9 already had priority 3 for the menuitem. |
…numberItemsMenu4" to "3:numberItemsMenu6 "
…e consistent with navigate to first menu item: nameMenuLinks roleMenu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @IsaDC. I found two more minor inconsistencies and fixed them. Merging.
Preview Tests