Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Navigation Menu Button test plan to V2 test format #996

Merged
merged 21 commits into from
Sep 19, 2024

Conversation

IsaDC
Copy link
Contributor

@IsaDC IsaDC commented Oct 3, 2023

@IsaDC
Copy link
Contributor Author

IsaDC commented Aug 12, 2024

@mcking65 this is ready for review.

@IsaDC IsaDC requested a review from mcking65 August 12, 2024 20:16
Copy link
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link text in the references for example is incorrect:
It is "APG Example: Actions Menu Button Using"
It should be: "APG Example: Navigation Menu Button"

In test 1 and test 2, step 3 in the instructions has an extra comma:

  1. Starting at the 'Navigate forwards from here' link,, navigate to the menu button.

In the following tests, Change assertion priority to 3 for "convey role of the focused item, 'menu item':
Test 4: Open a menu
Test 5: Open a menu to the last item

In Test 9: Navigate to an item in a menu by typing a character, The VoiceOver command "w" needs to specify the setting for single character quick nav off.

@mcking65
Copy link
Contributor

@IsaDC

wow, I just realized that I was looking at the wrong test plan in preview! I was looking at action menu button. I'm relooking now.

@IsaDC IsaDC requested a review from mcking65 September 11, 2024 16:10
@mcking65
Copy link
Contributor

@IsaDC

I revised my feedback after looking at the correct test plan ... it is very similar to what I previously posted.

@IsaDC
Copy link
Contributor Author

IsaDC commented Sep 11, 2024

@mcking65 I’ve implemented the required changes. Tests 7, 8, and 9 already had priority 3 for the menuitem.

…e consistent with navigate to first menu item: nameMenuLinks roleMenu
Copy link
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @IsaDC. I found two more minor inconsistencies and fixed them. Merging.

@mcking65 mcking65 merged commit bab79e2 into master Sep 19, 2024
8 checks passed
@mcking65 mcking65 deleted the tests/menu-button-navigation-refactor branch September 19, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants