-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Actions Menu Button Example Using element.focus() Test Plan to V2 Test Format #1122
Conversation
@mcking65 This Pull Request includes the feedback we discussed in today's CG meeting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example reference points to the activedescendant example in APG instead of to the element.focus example.
In Test 9: Navigate to an item in a menu by typing a character, the VoiceOver command needs to specify that letter quick nav is off.
In the following tests, change priority to 3 for the assertion "convey role of the focused item, 'menu item'":
- Test 4: Open a menu
- Test 5: Open a menu to the last item
@mcking65 All done :) |
…rt+up for request information about a menu item
…rt+up in test for request information about a menu item
There's a bug in the setup script for tests 8. If you first run setup for test 7, the test 8 setup will set focus to the wrong item. If you refresh browser cache, the test 8 script will then work correctly and set focus to the first item. To reproduce:
Expected behavior: Focus is set on action 1. Actual behavior: Focus is set on action 4. |
Thank you, @mcking65, for reporting this. I haven’t been able to reproduce the issue so far, as both setup scripts seem to be working correctly and setting focus as expected. @jscholes, could you take a look when you have a chance? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'm merging based on our Tuesday conversation.
I did push one more fix ... the references.csv for the other action menu button with active descendant plan was somehow modified in these files. I corrected that so now all the mods are just with this one test plan.
Preview Tests