Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Actions Menu Button Example Using element.focus() Test Plan to V2 Test Format #1122

Merged
merged 15 commits into from
Oct 31, 2024

Conversation

IsaDC
Copy link
Contributor

@IsaDC IsaDC commented Aug 28, 2024

@IsaDC IsaDC requested review from mzgoddard and mcking65 and removed request for mzgoddard August 28, 2024 23:26
@IsaDC
Copy link
Contributor Author

IsaDC commented Aug 28, 2024

@mcking65 This Pull Request includes the feedback we discussed in today's CG meeting.

Copy link
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example reference points to the activedescendant example in APG instead of to the element.focus example.

In Test 9: Navigate to an item in a menu by typing a character, the VoiceOver command needs to specify that letter quick nav is off.

In the following tests, change priority to 3 for the assertion "convey role of the focused item, 'menu item'":

  • Test 4: Open a menu
  • Test 5: Open a menu to the last item

@IsaDC
Copy link
Contributor Author

IsaDC commented Sep 11, 2024

@mcking65 All done :)

@mcking65
Copy link
Contributor

@IsaDC

There's a bug in the setup script for tests 8. If you first run setup for test 7, the test 8 setup will set focus to the wrong item. If you refresh browser cache, the test 8 script will then work correctly and set focus to the first item.

To reproduce:

  1. Open the test plan in Chrome.
  2. Open the test 7 test window.
  3. Run the setup script for test 7.
  4. Close the test 7 window .
  5. Open the test 8 test window.
  6. Run the test 8 setup.

Expected behavior: Focus is set on action 1.

Actual behavior: Focus is set on action 4.

@IsaDC
Copy link
Contributor Author

IsaDC commented Oct 23, 2024

@IsaDC

There's a bug in the setup script for tests 8. If you first run setup for test 7, the test 8 setup will set focus to the wrong item. If you refresh browser cache, the test 8 script will then work correctly and set focus to the first item.

To reproduce:

  1. Open the test plan in Chrome.
  2. Open the test 7 test window.
  3. Run the setup script for test 7.
  4. Close the test 7 window .
  5. Open the test 8 test window.
  6. Run the test 8 setup.

Expected behavior: Focus is set on action 1.

Actual behavior: Focus is set on action 4.

Thank you, @mcking65, for reporting this. I haven’t been able to reproduce the issue so far, as both setup scripts seem to be working correctly and setting focus as expected. @jscholes, could you take a look when you have a chance?

Copy link
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IsaDC

Looks good. I'm merging based on our Tuesday conversation.

I did push one more fix ... the references.csv for the other action menu button with active descendant plan was somehow modified in these files. I corrected that so now all the mods are just with this one test plan.

@mcking65 mcking65 merged commit 51f6f65 into master Oct 31, 2024
8 checks passed
@mcking65 mcking65 deleted the tests/menu-button-actions-refactor branch October 31, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants