Massive staging and barrier refactoring #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's an incomplete intermediary change. This commit doesn't work. It compiles tho. Changes: - Move buffer staging tracking to vk_buffer - Sketch automatic buffer barriers tied to vk_combuf - Remove all combuf handling from staging. That was just gross. Breaks: - Everything. - RT AS building is commented out for now
it render quite a few traditional frames but then fails with cross-cmdbuf sync validation errors
- print out vkQueueSubmit with its semaphores - print out buffer barriers - print out when buffer copy submission happens - print various ref_vk initialization stages
Validation was complaining about odd SYNC-HAZARD-WRITE-AFTER-READ lack of buffer barrier at the very beginning of a frame, while I thought that command buffers are properly serialized by semaphores. Turns out, `VkSubmitInfo::pWaitDstStageMask` should accompany each wait semaphore with its corresponding stage. Properly setting TOP_OF_PIPE for the wait semaphore of a previous submission fixes the complaint.
This is likely no the right way to do this. Address this when focusing on correct gamma overall for traditional renderer. Currently this is here just to make it have some non-zero values early.
Previous 20.04 doesn't have the latest Vulkan SDK. Also print deps script commands verbosely for easier CI debugging.
w23
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In its own branch until it can render at least one frame