Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4417 fix: Update parser.py from Earley to Lalr #4449

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jolliano
Copy link

I simply changed the parser to use the LALR algorithm instead of the slow earley algorithm

Commit message

Updated the parser from Lark's earley algorithm to Lark's LALR

Description for the changelog

Updated the parser from Lark's earley algorithm to Lark's LALR

I simply changed the parser to use the LALR algorithm instead of the slow earley algorithm
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.90%. Comparing base (db8dcc7) to head (0b213b5).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (db8dcc7) and HEAD (0b213b5). Click for more details.

HEAD has 21 uploads less than BASE
Flag BASE (db8dcc7) HEAD (0b213b5)
141 120
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4449       +/-   ##
===========================================
- Coverage   92.01%   57.90%   -34.11%     
===========================================
  Files         119      119               
  Lines       16692    16692               
  Branches     2805     2805               
===========================================
- Hits        15359     9666     -5693     
- Misses        915     6347     +5432     
- Partials      418      679      +261     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper
Copy link
Member

i don't think this really fixes the issue since the grammar itself needs to be changed in order for the lalr algorithm to work. marking as draft until the tests are fixed

@charles-cooper charles-cooper marked this pull request as draft January 14, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants